rzmk/learnhouse
1
0
Fork 0
mirror of https://github.com/rzmk/learnhouse.git synced 2025-12-19 04:19:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: various bugs + improve api readability

Browse source
This commit is contained in:
swve 2023-11-29 21:59:35 +01:00
parent 7daf6df5a0
commit 2bf80030d7
21 changed files with 98 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

2
apps/api/src/security/rbac/rbac.py
View file

@ -16,7 +16,7 @@ async def authorization_verify_if_element_is_public(
element_uuid: str,
action: Literal["read"],
db_session: Session,
):
):
element_nature = await check_element_type(element_uuid)
# Verifies if the element is public
if element_nature == ("courses" or "collections") and action == "read":

5
apps/api/src/security/rbac/utils.py
View file

@ -5,6 +5,7 @@ async def check_element_type(element_id):
"""
Check if the element is a course, a user, a house or a collection, by checking its prefix
"""
print("element_id", element_id)
if element_id.startswith("course_"):
return "courses"
elif element_id.startswith("user_"):
@ -13,12 +14,14 @@ async def check_element_type(element_id):
return "houses"
elif element_id.startswith("org_"):
return "organizations"
elif element_id.startswith("coursechapter_"):
elif element_id.startswith("chapter_"):
return "coursechapters"
elif element_id.startswith("collection_"):
return "collections"
elif element_id.startswith("activity_"):
return "activities"
elif element_id.startswith("role_"):
return "roles"
else:
raise HTTPException(
status_code=status.HTTP_409_CONFLICT,